Scripts: update buildnumber to use timezone-aware datetime #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5971 +/- ##
==========================================
- Coverage 55.73% 55.72% -0.01%
==========================================
Files 490 490
Lines 68125 68125
==========================================
- Hits 37967 37963 -4
- Misses 27586 27589 +3
- Partials 2572 2573 +1 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
May 8, 2024
ohill
approved these changes
May 8, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running
makewill get this deprecation warning for newer versions of python:This is because utcnow is timezone-aware, and the earlier datetime call is naive. To make this consistent, we just mark all to UTC, to make consistent with the comment for setting the epoch.
Test Plan
Verified that
./scripts/buildnumber.pyreturned output without deprecation warnings.Verified on 3.12.2 and 3.8.10 (version shipped with Ubuntu 20.04).