build: support SWAGGER_CONVERTER_API override #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
previously approved these changes
Mar 29, 2024
onetechnical
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5968 +/- ##
==========================================
+ Coverage 55.71% 55.73% +0.02%
==========================================
Files 490 490
Lines 68125 68125
==========================================
+ Hits 37954 37971 +17
+ Misses 27599 27585 -14
+ Partials 2572 2569 -3 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Mar 29, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Makefile in daemon/algod/api to support setting a different SWAGGER_CONVERTER_API, and starts up a Github workflow service container for
swaggerapi/swagger-converterwhen running the codegen_verification job.Test Plan
Check codegen_verification Github job to make sure it works.