Docker: Remove usage of gosu and replace with su
#5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm noticing that there's a build failure, however also unable to drill in on build failures due to what appears may be a permission related issue. All workflow steps in the attached screenshot are not clickable for me.
|
onetechnical
changed the title
gosu and replace with sugosu and replace with su
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5951 +/- ##
==========================================
+ Coverage 55.71% 55.72% +0.01%
==========================================
Files 489 489
Lines 68111 68111
==========================================
+ Hits 37950 37958 +8
+ Misses 27586 27583 -3
+ Partials 2575 2570 -5 ☔ View full report in Codecov by Sentry. |
onetechnical
approved these changes
Mar 13, 2024
algorandskiy
approved these changes
Mar 14, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace usage of upstream
gosucommand in Docker containers.suis available in the environment, and usingsushould reduce security exposure vs using upstream (Ubuntu) managedgosudependency.At the time of writing security scanning tools such as grype/Snyk/Docker Scout are all finding issues in the
gosulinked stdlib (from go1.19.8), which this will remediate.Test Plan
Changed were tested by:
gosuto identify usagesdocker run -it algorand/algod:latest bash/node/run/run.shto usesucommand/node/run/run.shPermutations tested:
ALGORAND_DATAhas been inspected (algorand:algorandowner expected)Notes:
makescript./Dockerfilewas not done as I'm uncertain about build target to use for creating the necessary files req. in the copy step. To workaround this issue current Docker image was pulled from Docker Hub, and whererun.shchanges subsequently were injected.