goal: support simulate scratch in exec trace #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbroder-algo
previously approved these changes
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #5589 +/- ##
==========================================
+ Coverage 55.75% 55.82% +0.07%
==========================================
Files 446 446
Lines 63462 63464 +2
==========================================
+ Hits 35382 35429 +47
+ Misses 25703 25667 -36
+ Partials 2377 2368 -9
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
reviewed
Jul 20, 2023
jasonpaulos
approved these changes
Jul 20, 2023
bbroder-algo
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5563 forgot to add support for goal to return scratch slot changes in exec trace, this is an enhancement.
Test Plan
e2e script test for goal to return stack and scratch changes in exec trace.