chore: use string builder instead of string concatenation in catchup service #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5572 +/- ##
==========================================
- Coverage 55.79% 55.77% -0.02%
==========================================
Files 446 446
Lines 63418 63420 +2
==========================================
- Hits 35381 35371 -10
- Misses 25668 25678 +10
- Partials 2369 2371 +2
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@bbroder-algo @winder can you review this? |
|
Thanks for the contribution |
winder
changed the title
bbroder-algo
changed the title
jannotti
reviewed
Jul 21, 2023
| @@ -744,17 +745,19 @@ func (s *Service) fetchRound(cert agreement.Certificate, verifier *agreement.Asy | |||
| if cert.Round == fetchedCert.Round && | |||
| cert.Proposal.BlockDigest != fetchedCert.Proposal.BlockDigest && | |||
| fetchedCert.Authenticate(*block, s.ledger, verifier) == nil { | |||
| s := "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n" | |||
There was a problem hiding this comment.
Where is the test for this change?
There was a problem hiding this comment.
fwiw, I ran it in go playground and it worked.
|
BenchmarkPlusEq-8 1515818 779.0 ns/op |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hello Algorand team
I replaced string concatenation with a builder, that's faster and more efficient, concatenation with
+is also too expensive.