perf tests: use metrics for memory usage charts #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5565 +/- ##
==========================================
+ Coverage 55.80% 55.83% +0.02%
==========================================
Files 446 446
Lines 63417 63418 +1
==========================================
+ Hits 35389 35407 +18
+ Misses 25663 25650 -13
+ Partials 2365 2361 -4
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
approved these changes
Jul 13, 2023
iansuvak
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current heapwatch tooling uses only pprof heap profile for memory usage charts and reports although there are runtime metrics collected and available.
Test Plan
Tested locally, chart sample attached. The solid line is the old pprof data, all non-solid lines are new from runtime metrics.
