build: remove sqlite from release configurations #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5562 +/- ##
==========================================
- Coverage 55.88% 55.84% -0.04%
==========================================
Files 446 446
Lines 63275 63275
==========================================
- Hits 35360 35336 -24
- Misses 25555 25570 +15
- Partials 2360 2369 +9 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jul 13, 2023
jannotti
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was just talking with @onetechnical about how our build containers install sqlite3 unnecessarily, since the go-sqlite3 package contains its own version-tracked distribution of sqlite's source code. The only reason we add it to scripts like configure_dev.sh is for usage in the CLI for development and debugging, but it is not a release or build-time dependency, so I am removing it in this PR.
Test Plan
Existing tests and builds should succeed as before.