ledger: fix catchpoint pending hashes locking #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icorderi
force-pushed
the
fix/reader-writer-catchpoint
branch
from
b56a599 to
3a254c3
Compare
algorandskiy
approved these changes
Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #5534 +/- ##
==========================================
- Coverage 55.83% 55.82% -0.02%
==========================================
Files 446 446
Lines 63262 63262
==========================================
- Hits 35323 35313 -10
- Misses 25566 25583 +17
+ Partials 2373 2366 -7
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Jul 10, 2023
|
Agree, a test would be nice but it appears fairy hard to repro on small DB. I think it is worth investigating if the MT could write data into a temporal DB since it is not needed after finishing the FC process (well, unless one want to produce catchpoints but it is handled on startup - MT will be regenerated if the config wants to). |
algorandskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5451 introduced a bug, the catchpoint merkle tree generation needs to be kept on a separate readonly connection for it to make forward progress.
This PR add the required method to the
Readerinterface for the store, so it becomes available via theSnapshotscope.There is an implicit contract that the snapshot is going through a separate read-only handle to the sqlite db.
If this were ever to change, this will break again.
Test Plan