Runtime: Add delete-if-exists check for the no longer used indexer.sqlite file… #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in genesis data directory..
gmalouf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5531 +/- ##
==========================================
- Coverage 55.78% 55.06% -0.73%
==========================================
Files 446 446
Lines 63262 63272 +10
==========================================
- Hits 35293 34841 -452
- Misses 25590 26042 +452
- Partials 2379 2389 +10
... and 55 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
previously approved these changes
Jul 7, 2023
onetechnical
requested changes
Jul 10, 2023
|
Still not sure if this is a good idea to bake in, or if we should just let legacy users manage with a release note. Seems like it would affect a small number of users. |
winder
approved these changes
Jul 10, 2023
onetechnical
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add delete-if-exists check for the no longer used indexer.sqlite file in genesis data directory.
Test Plan
Ran node locally with indexer.sqlite file present, not present, and initial condition with data directory not created yet.