Chore: Small cleanups for clarity #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
force-pushed
the
logicsig-pooling-prep
branch
from
cf8f1ee to
f31d54d
Compare
I'm doing a larger bit of work to enable logicsig cost pooling and I found myself making these changes along the way. It's easier to review by extracting them into their own PR. This does three things. Introduces and uses: ``` func (msig MultisigSig) Signatures() int ``` for the sevral places we need to examine a MultiSig to count the number of sub signatures present. Uses the pre-existing `func (s *Signature) Blank() bool` in many places. Renames `EvalContext.runModeFlags` to simply `EvalContext.runMode` because it takes on a single value, it can't be, for example: `ModeSig | ModeApp`, it must be one or the other.
jannotti
force-pushed
the
logicsig-pooling-prep
branch
from
f31d54d to
7d2c2d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #5526 +/- ##
==========================================
- Coverage 55.81% 55.79% -0.02%
==========================================
Files 446 446
Lines 63228 63213 -15
==========================================
- Hits 35290 35271 -19
Misses 25572 25572
- Partials 2366 2370 +4
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
requested review from
algorandskiy,
jasonpaulos,
algonautshant and
ahangsu
algorandskiy
reviewed
Jul 5, 2023
ahangsu
approved these changes
Jul 5, 2023
jasonpaulos
approved these changes
Jul 5, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing a larger bit of work to enable logicsig cost pooling and I found myself making these changes along the way. It's easier to review by extracting them into their own PR. This does four things.
for the several places we need to examine a MultiSig to count the number of sub signatures present.
Uses the pre-existing
func (s *Signature) Blank() boolin many places.Renames
EvalContext.runModeFlagsto simplyEvalContext.runModebecause it takes on a single value, it can't be, for example:ModeSig | ModeApp, it must be one or the other.Improves tests by making it so that sample transactions created for versions below
rekeyingEnabledVeriondon't have theirRekeyAddressset.