bugfix: ensure blockservice callbacks are not nil #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
Jun 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #5518 +/- ##
==========================================
- Coverage 55.86% 55.80% -0.06%
==========================================
Files 446 446
Lines 63256 63258 +2
==========================================
- Hits 35336 35303 -33
- Misses 25558 25583 +25
- Partials 2362 2372 +10
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@cce caught an issue with a #5472 after it was merged. Here is the fix to ensure clean shutdown of the server since before we weren't checking that
OnReleasecallback isn't nil.Test Plan
Existing tests