API: Allow DELETE calls #5515
Merged
API: Allow DELETE calls #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5515 +/- ##
=======================================
Coverage 55.78% 55.79%
=======================================
Files 446 446
Lines 63228 63228
=======================================
+ Hits 35274 35275 +1
+ Misses 25583 25581 -2
- Partials 2371 2372 +1
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Jun 29, 2023
winder
approved these changes
Jun 29, 2023
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The algod REST API has some methods that require DELETE calls. In particular, I want to delete a participation key. Making a DELETE call currently gives the following error:
This PR adds the DELETE method to the the Access-Control-Allow-Methods so the DELETE endpoints will work.
Test Plan
I started the node, generated a key, and then deleted the key via the API to make sure it worked.