tests: Fix catchpoint catchup tests to use relay for catchup #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
winder,
algonautshant,
algorandskiy and
ahangsu
Codecov Report
@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
- Coverage 55.83% 55.80% -0.03%
==========================================
Files 446 446
Lines 63223 63223
==========================================
- Hits 35299 35282 -17
- Misses 25561 25573 +12
- Partials 2363 2368 +5 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jun 28, 2023
ahangsu
reviewed
Jun 28, 2023
ahangsu
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly test failures for these tests. They are all running the same copy/pasted code so the fix is identical.
They were previously trying to use catchpoint catchup where the two nodes in the network were generating catchpoints, but the relay was not. This won't ever work since the ledger request always uses relays as its peer list and cycles through those.
It previously passed because the catchpoint service returned 200 on starting up, but with e96d104 we now do validation via a HEAD request before returning success on catchpoint service startup.
Test Plan
Tests pass locally--Nightly run is https://app.circleci.com/pipelines/github/algorand/go-algorand/15279/workflows/03a01ff7-4437-46c8-a723-3a4957966f94