goal: account info with deleted asset suppress error and better output #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5504 +/- ##
==========================================
- Coverage 55.82% 55.80% -0.03%
==========================================
Files 446 446
Lines 63224 63229 +5
==========================================
- Hits 35292 35282 -10
- Misses 25565 25576 +11
- Partials 2367 2371 +4
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
approved these changes
Jun 27, 2023
jannotti
reviewed
Jun 27, 2023
winder
approved these changes
Jun 27, 2023
|
I am not sure we have the same issue for opting into deleted app, for we do not ask for application info... Do we want to support that? |
We don't need to fetch the app params to display app local states (as @ahangsu points out), so deleted apps are a non-issue |
jasonpaulos
approved these changes
Jun 27, 2023
algorandskiy
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Suppress the asset search error with a better output on deleted/unknown asset (404 resp on querying such asset from algod). An example output is shown as follows:
Should resolve #5154.
Test Plan
An e2e test for
goal account infowith deleted asset.