Build: Disable goexperiments in our builds due to issue present in Go 1.20.5 #5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
changed the title
| # Disable go experiments during build as of go 1.20.5 due to | ||
| # https://github.com/golang/go/issues/60825 | ||
| # Likely fix: https://go-review.googlesource.com/c/go/+/503937/6/src/runtime/race_arm64.s | ||
| export GOEXPERIMENT=none |
There was a problem hiding this comment.
GOEXPERIMENT= I guess?
There was a problem hiding this comment.
I went off: https://pkg.go.dev/internal/goexperiment
Codecov Report
@@ Coverage Diff @@
## master #5484 +/- ##
==========================================
+ Coverage 55.64% 55.66% +0.02%
==========================================
Files 448 448
Lines 63493 63493
==========================================
+ Hits 35328 35345 +17
+ Misses 25772 25752 -20
- Partials 2393 2396 +3 see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jun 21, 2023
onetechnical
approved these changes
Jun 21, 2023
algorandskiy
added a commit
to algorandskiy/go-algorand
that referenced
this pull request
Jul 18, 2023
…nt in Go 1.20.5 (algorand#5484)" This reverts commit 0824e4a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable goexperiments in our builds due to issue present in Go 1.20.5 to address test issues on ARM64 builds.
Test Plan
Run full build successfully.