Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update falcon to v0.1.0 for new CFLAGS #5460

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

cce
Copy link
Contributor

@cce cce commented Jun 8, 2023

Summary

This pulls in algorand/falcon#13 to silence a compiler warning on Mac with clang.

Test Plan

Existing tests should pass.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #5460 (8efb3f4) into master (3fbc4b6) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
+ Coverage   55.56%   55.60%   +0.04%     
==========================================
  Files         448      448              
  Lines       63375    63375              
==========================================
+ Hits        35216    35242      +26     
+ Misses      25786    25762      -24     
+ Partials     2373     2371       -2     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce added the Enhancement label Jun 8, 2023
Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally

@bbroder-algo bbroder-algo merged commit fd60def into algorand:master Jun 8, 2023
@cce cce deleted the update-falcon-cflags branch June 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants