flake: TestLedgerContinuesOnVotersCallbackFailure #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Jun 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #5454 +/- ##
==========================================
- Coverage 55.60% 55.59% -0.02%
==========================================
Files 447 447
Lines 63395 63395
==========================================
- Hits 35253 35245 -8
- Misses 25760 25766 +6
- Partials 2382 2384 +2 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
Jun 7, 2023
algorandskiy
requested changes
Jun 7, 2023
added 2 commits
June 7, 2023 11:25
|
After digging into with Chris, the test is useless now after making |
algorandskiy
previously approved these changes
Jun 7, 2023
cce
reviewed
Jun 9, 2023
ledger/ledger_test.go
Outdated
| @@ -3091,32 +3091,6 @@ type errorCommitListener struct{} | |||
| func (l *errorCommitListener) OnPrepareVoterCommit(oldBase basics.Round, newBase basics.Round, _ ledgercore.LedgerForSPBuilder) { | |||
There was a problem hiding this comment.
We also need to remove the errorCommitListener type
|
For more background, in #5085 the OnPrepareVoterCommit method was changed to not return an error, so as part of that change the errorCommitListener was updated (it used to return an error), but no longer does anything differently from the mockCommitListener in the test above. |
added 2 commits
June 9, 2023 11:42
algorandskiy
approved these changes
Jun 12, 2023
cce
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove a flakey test deemed no longer needed along with a type that its removal orphaned.
Test Plan
CI