-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: don't use deprecated set-output in github actions #5453
Merged
algorandskiy
merged 9 commits into
algorand:master
from
tzaffi:tools-workflow-replace-set-output
Jun 6, 2023
Merged
CI: don't use deprecated set-output in github actions #5453
algorandskiy
merged 9 commits into
algorand:master
from
tzaffi:tools-workflow-replace-set-output
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5453 +/- ##
==========================================
+ Coverage 55.47% 55.50% +0.03%
==========================================
Files 447 447
Lines 63290 63290
==========================================
+ Hits 35108 35127 +19
+ Misses 25800 25788 -12
+ Partials 2382 2375 -7 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
approved these changes
Jun 6, 2023
cce
changed the title
bugfix: don't use deprecated set-output in github actions
CI: don't use deprecated set-output in github actions
Jun 6, 2023
algobarb
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. LGTM
algorandskiy
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Github Action's
set-output
command is deprecated as I discovered when looking closer at the results of the Test tools modules workflow added in #5381 .I'm replacing this usage by saving / reading from GA's env var file
$GITHUB_ENV
Test Plan
CI
We can verify that everything's still running via this intentional test fail.