netgoal: fix large db generation #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5445 +/- ##
==========================================
- Coverage 55.40% 54.18% -1.23%
==========================================
Files 447 447
Lines 63313 63328 +15
==========================================
- Hits 35080 34312 -768
- Misses 25842 26612 +770
- Partials 2391 2404 +13
... and 71 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
reviewed
Jun 2, 2023
cce
reviewed
Jun 5, 2023
cce
reviewed
Jun 5, 2023
| @@ -159,6 +159,7 @@ | |||
| ], | |||
| "FeeSink": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ", | |||
| "RewardsPool": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ", | |||
| "RewardsPoolBalance": 125000000000000, | |||
There was a problem hiding this comment.
I'm curious, was this required to get it going? Or did rerunning netgoal just generate this dirty change
There was a problem hiding this comment.
I did not add this in manually, it was modified by make if that's what you mean.
There was a problem hiding this comment.
maybe we just remove this line then?
There was a problem hiding this comment.
sure, I have removed it.
* Use the netState structure to hold a counter for number of deterministic accounts created * Two separate functions for keypair and deterministicKeypair * Simplify delay loop in netdeploy generate
algorandskiy
reviewed
Jun 5, 2023
algorandskiy
previously approved these changes
Jun 6, 2023
algorandskiy
approved these changes
Jun 7, 2023
algorandskiy
approved these changes
Jun 7, 2023
cce
approved these changes
Jun 7, 2023
algorandskiy
changed the title
AlgoAxel
added a commit
to AlgoAxel/go-algorand
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the following changes to support large-scale testing:
netgoal generateto prevent OOM crashes if the in-memory database outpaces flushes to diskTesting
make install. This is a manual port of relevant fixes from a development branch. In that branch, these fixes are being used to produce large scale testing, and the changes introduced here were vital to unblocking issues in infrastructure.time netgoal build -r "~/networks/deterministic" -n "deterministic" --recipe test/testdata/deployednettemplates/recipes/bootstrappedScenario/recipe.json --gen-db-files- watched this command with extra debug lines to observe the index for keypair being used and incremented as expected.