build: fix shadow linter in debug tools #5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
changed the title
winder
reviewed
Jun 2, 2023
Comment on lines
-398
to
+391
| err := followerNode.SetSyncRound(syncRound) | ||
| err = followerNode.SetSyncRound(syncRound) |
There was a problem hiding this comment.
cool! This is using the follower to copy txns into a ledger?
There was a problem hiding this comment.
used to catchup node to a specific round, and then use raw ledger to add transactions from a file/directory
winder
approved these changes
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #5442 +/- ##
===========================================
- Coverage 55.41% 39.86% -15.56%
===========================================
Files 447 447
Lines 63313 63313
===========================================
- Hits 35086 25239 -9847
- Misses 25841 35675 +9834
- Partials 2386 2399 +13 see 261 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR #5420 introduced couple linter issues that were missed by CI because the new linter (shadowing) was enabled after that PR.
Test Plan
This is a debug tool build fix.