Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky test TestVotersReloadFromDiskPassRecoveryPeriod #5436

Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented May 31, 2023

Summary

The title says it all. Related to #5432, reduce flakiness in CI testing.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #5436 (fa721c0) into master (aa6a5bb) will decrease coverage by 7.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5436      +/-   ##
==========================================
- Coverage   55.41%   48.14%   -7.28%     
==========================================
  Files         447      447              
  Lines       63233    63233              
==========================================
- Hits        35043    30444    -4599     
- Misses      25798    30287    +4489     
- Partials     2392     2502     +110     

see 178 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahangsu ahangsu requested a review from algorandskiy May 31, 2023 15:58
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algorandskiy algorandskiy merged commit 8d73f00 into algorand:master May 31, 2023
@ahangsu ahangsu deleted the skip-flaky-lru-cache-related-test branch May 31, 2023 16:14
tzaffi pushed a commit to tzaffi/go-algorand that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants