sortition: use external sortition package #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
commented
May 30, 2023
algorandskiy
previously approved these changes
May 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #5429 +/- ##
==========================================
- Coverage 55.40% 55.39% -0.01%
==========================================
Files 447 447
Lines 63294 63294
==========================================
- Hits 35065 35062 -3
- Misses 25836 25844 +8
+ Partials 2393 2388 -5
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
previously approved these changes
May 30, 2023
cce
dismissed stale reviews from tzaffi, bbroder-algo, and algorandskiy
via
fd031b3
tzaffi
reviewed
May 31, 2023
|
@cce please update go.sum |
tzaffi
reviewed
Jun 2, 2023
| rapid.Just(proto.RedoCommitteeSize), | ||
| rapid.Just(proto.DownCommitteeSize), | ||
| ).Draw(t, "expectedSize").(uint64) | ||
| //expectedSize := rapid.Uint64Range(1, totalMoney).Draw(t, "expectedSize").(uint64) // draw random |
There was a problem hiding this comment.
Suggested change
| //expectedSize := rapid.Uint64Range(1, totalMoney).Draw(t, "expectedSize").(uint64) // draw random |
Or if you really need for local testing, it should be placed in the scope of totalMoney
tzaffi
reviewed
Jun 2, 2023
winder
approved these changes
Jun 2, 2023
algorandskiy
approved these changes
Jun 2, 2023
algorandskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the data/committee package to use the new separate github.com/algorand/sortition package, which contains the same code as in github.com/algorand/data/committee/sortition.
Test Plan
Existing tests should pass, and added a new property-based test TestCompareSortitionImpls that I ran for 10M iterations.