lint: enable staticcheck for test code and fix issues #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5401 +/- ##
==========================================
- Coverage 55.38% 55.35% -0.03%
==========================================
Files 447 447
Lines 63312 63312
==========================================
- Hits 35063 35045 -18
- Misses 25857 25870 +13
- Partials 2392 2397 +5 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
previously approved these changes
May 19, 2023
|
@cce please resolve conflicts |
algorandskiy
approved these changes
Jun 2, 2023
cce
commented
Jun 2, 2023
algonautshant
approved these changes
Jun 2, 2023
| @@ -662,7 +662,7 @@ func BenchmarkBuildVerify(b *testing.B) { | |||
| sig, err := signerInRound.SignBytes(data[:]) | |||
| require.NoError(b, err, "failed to create keys") | |||
|
|
|||
| partkeys = append(partkeys, signer) | |||
| //partkeys = append(partkeys, signer) | |||
There was a problem hiding this comment.
Why not completely remove this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The staticcheck linter is one of the golangci-lint linters enabled by default that provides a wide range of advice; this PR enables it for test code and fixes the handful of issues it raised.
Test Plan
Existing tests should pass.