Bookkeeping: improve block documentation since no-low-resources #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5383 +/- ##
==========================================
- Coverage 55.41% 55.37% -0.05%
==========================================
Files 452 452
Lines 63643 63643
==========================================
- Hits 35270 35243 -27
- Misses 25972 25989 +17
- Partials 2401 2411 +10
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahangsu
approved these changes
May 31, 2023
|
@jannotti is this ok |
|
We've lost one important point that applies to mainnet and testnet - they're counters started when support for TxCounter was added, so they have no TxCounter at all early on, and it starts at 0 sometime later than genesis. |
algorandskiy
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates commentary in the
BlockHeaderto supportTxCounters starting at nonzero numbers in genesis blocks (in support of banning low asset/app resources)