Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: EvalDelta and ConsensusParams x-repo type checks #5381

Merged
merged 42 commits into from
Jun 5, 2023
Merged

tools: EvalDelta and ConsensusParams x-repo type checks #5381

merged 42 commits into from
Jun 5, 2023

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented May 12, 2023 •
edited
Loading

Summary

1. Introduce recursive go test ./... in CI and go mod tidy both in Makefile and CI

It turns out that the x-repo-types tests weren't actually running in C.I. This is because go test ./... (and gotestsum) don't recurse into module directories (those that have a go.mod file).

We can see that this commit very happily passed CI:
image

References

Summary of CI/Makefile Changes:

2. Introduce more cross-type checks

  • EvalDelta in data.transactions vs. in go-algorand-sdk's types.
  • ConsensusParams in config vs. in go-algorand-sdk's protocol.config

Context

EvalDelta was introduced to fix failing Indexer end-to-end tests. See:

ConsensusParams was moved from indexer to go-algorand-sdk in algorand/go-algorand-sdk#543

Related Issues

F.A.Q.

Which tests were being skipped and what is the impact going forward?

  • cmd/partitiontest_linter/linter_test.go - STILL SKIPPED GOING FORWARD
  • tools/block-generator/generator/generate_test.go
  • tools/block-generator/generator/server_test.go
  • tools/block-generator/generator/utils_test.go
  • tools/x-repo-types/typeAnalyzer/typeAnalyzer_test.go
  • tools/x-repo-types/xrt_test.go

Testing

Purely on CI

@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #5381 (65351c4) into master (5faa4d0) will decrease coverage by 5.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5381      +/-   ##
==========================================
- Coverage   55.44%   50.13%   -5.32%     
==========================================
  Files         447      447              
  Lines       63272    79614   +16342     
==========================================
+ Hits        35083    39916    +4833     
- Misses      25810    37321   +11511     
+ Partials     2379     2377       -2

see 418 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced May 12, 2023
Closed
Merged
Merged
winder

This comment was marked as outdated.

Sign in to view

@tzaffi tzaffi changed the title EvalDelta type check tools: EvalDelta type check May 19, 2023
@tzaffi tzaffi marked this pull request as ready for review May 19, 2023 20:34
winder
winder previously approved these changes May 26, 2023
View reviewed changes
tzaffi
tzaffi commented May 26, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@tzaffi tzaffi changed the title tools: EvalDelta type check tools: EvalDelta + ConsensusParams type checks May 26, 2023
@tzaffi tzaffi changed the title tools: EvalDelta + ConsensusParams type checks tools: EvalDelta & ConsensusParams x-repo type checks + bugfix: start testing subdirectories with a go.mod May 27, 2023
@tzaffi tzaffi changed the title tools: EvalDelta & ConsensusParams x-repo type checks + bugfix: start testing subdirectories with a go.mod tools: EvalDelta & ConsensusParams x-repo type checks + bugfix: start testing subdirectories with a go.mod May 27, 2023
@tzaffi tzaffi requested a review from algorandskiy June 2, 2023 15:01
cce
cce reviewed Jun 2, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@tzaffi tzaffi changed the title enhancement: 1. start testing nested go modules + 2. tools: EvalDelta & ConsensusParams x-repo type checks enhancement: 1. better CI handling of nested go modules + 2. tools: EvalDelta & ConsensusParams x-repo type checks Jun 5, 2023
@tzaffi tzaffi requested review from cce and algorandskiy June 5, 2023 17:11
@algorandskiy algorandskiy changed the title enhancement: 1. better CI handling of nested go modules + 2. tools: EvalDelta & ConsensusParams x-repo type checks tools: EvalDelta and ConsensusParams x-repo type checks Jun 5, 2023
@algorandskiy algorandskiy merged commit 4b70342 into algorand:master Jun 5, 2023
This was referenced Jun 6, 2023
Merged
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request Jul 11, 2023
Merged
@onetechnical onetechnical mentioned this pull request Jul 24, 2023
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cce cce cce approved these changes

@algorandskiy algorandskiy algorandskiy approved these changes

@excalq excalq Awaiting requested review from excalq excalq was automatically assigned from algorand/devops

@algobarb algobarb Awaiting requested review from algobarb algobarb was automatically assigned from algorand/devops

@winder winder Awaiting requested review from winder

@onetechnical onetechnical Awaiting requested review from onetechnical

@icorderi icorderi Awaiting requested review from icorderi

@gmalouf gmalouf Awaiting requested review from gmalouf

Assignees

@tzaffi tzaffi

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tzaffi @cce @winder @algorandskiy @ahangsu @jannotti