metrics: add counters for checkAlreadyCommitted, split "InLedger" counters by reason #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
changed the title
algorandskiy
previously approved these changes
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #4881 +/- ##
==========================================
- Coverage 54.06% 54.03% -0.03%
==========================================
Files 427 427
Lines 53474 53519 +45
==========================================
+ Hits 28909 28920 +11
- Misses 22299 22329 +30
- Partials 2266 2270 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 8, 2022
This was referenced Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on #4839 this adds metrics for different errors returned by checkAlreadyCommitted, which calls TestTransactionGroup. It also adds information to the LeaseInLedger and TransactionInLedger errors to split separate counters for whether a txn/lease was already seen on-chain, or in the pending block evaluator.
Test Plan
Extended TestTxHandlerRememberReportErrorsWithTxPool to use the new counters.