Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txHandler: disable canonical hashmap by default #4877

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

Disabled the second level check after performance concerns and TX vs agreement messages processing competition.

Test Plan

Existing tests

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #4877 (674509c) into master (c0c5a94) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
- Coverage   54.01%   54.00%   -0.02%     
==========================================
  Files         426      426              
  Lines       53425    53425              
==========================================
- Hits        28859    28852       -7     
- Misses      22305    22311       +6     
- Partials     2261     2262       +1     
Impacted Files Coverage Δ
config/localTemplate.go 43.75% <ø> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 67.06% <0.00%> (-2.39%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
ledger/acctupdates.go 69.48% <0.00%> (+0.24%) ⬆️
ledger/testing/randomAccounts.go 57.23% <0.00%> (+0.61%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/tracker.go 75.10% <0.00%> (+0.84%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 697c811 into algorand:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants