Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchpoint Dump Utility: catchpointdump now supports tar.gz #4743

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

almog-t
Copy link
Contributor

@almog-t almog-t commented Nov 3, 2022

Catchpoint dump utility now supports both catchpoints packed as .tar files and catchpoints compressed as .tar.gz files, like those created by e2e tests.

@almog-t almog-t requested a review from algorandskiy November 3, 2022 11:44
@almog-t almog-t changed the title catchpointdump now supports tar.gz Catchpoint Dump Utility: catchpointdump now supports tar.gz Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #4743 (ee452da) into master (995ae47) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4743      +/-   ##
==========================================
- Coverage   54.59%   54.02%   -0.58%     
==========================================
  Files         414      414              
  Lines       53517    53517              
==========================================
- Hits        29219    28913     -306     
- Misses      21878    22178     +300     
- Partials     2420     2426       +6     
Impacted Files Coverage Δ
cmd/algofix/deadlock.go 3.12% <0.00%> (-84.38%) ⬇️
tools/network/dnssec/resolver.go 37.66% <0.00%> (-46.76%) ⬇️
util/condvar/timedwait.go 71.42% <0.00%> (-28.58%) ⬇️
...od/api/server/lib/middlewares/connectionLimiter.go 75.00% <0.00%> (-16.67%) ⬇️
cmd/algofix/fix.go 23.87% <0.00%> (-15.06%) ⬇️
crypto/stateproof/builder.go 76.19% <0.00%> (-13.34%) ⬇️
catchup/universalFetcher.go 84.90% <0.00%> (-11.33%) ⬇️
data/basics/teal.go 16.47% <0.00%> (-10.59%) ⬇️
cmd/tealdbg/cdtSession.go 57.14% <0.00%> (-9.68%) ⬇️
crypto/multisig.go 37.10% <0.00%> (-7.55%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algorandskiy
algorandskiy previously approved these changes Nov 3, 2022
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Please update the magic and it is good to go.

cmd/catchpointdump/file.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants