Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix after boxes and prefetcher remerge #4716

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

#4149 changed test client API
#4352 used old API

This is a test

@algorandskiy algorandskiy self-assigned this Nov 1, 2022
@algorandskiy algorandskiy marked this pull request as ready for review November 1, 2022 01:55
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4716 (fe686b6) into master (e6f396b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
+ Coverage   54.34%   54.36%   +0.02%     
==========================================
  Files         414      414              
  Lines       53504    53504              
==========================================
+ Hits        29078    29090      +12     
+ Misses      22014    22008       -6     
+ Partials     2412     2406       -6     
Impacted Files Coverage Δ
ledger/internal/eval.go 48.99% <0.00%> (ø)
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.75%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
ledger/accountdb.go 72.43% <0.00%> (+0.15%) ⬆️
ledger/catchpointtracker.go 60.59% <0.00%> (+0.74%) ⬆️
data/transactions/verify/txn.go 77.14% <0.00%> (+0.95%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algorandskiy Thanks for catching + fixing.

@algorandskiy algorandskiy merged commit 97c232d into algorand:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants