tests: improve logging in expect tests #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
requested review from
michaeldiamant,
algonautshant,
winder and
a user
algorandskiy
commented
Aug 12, 2022
| @@ -53,22 +54,25 @@ proc ::AlgorandGoal::Abort { ERROR } { | |||
|
|
|||
| log_user 1 | |||
| set NODE_DATA_DIR $::GLOBAL_TEST_ROOT_DIR/Primary | |||
| if { [info exists ::NODE_DATA_DIR] } { | |||
| if { [file exists $NODE_DATA_DIR] } { | |||
There was a problem hiding this comment.
there is was a copy-paste error
algorandskiy
force-pushed
the
pavel/expect-4
branch
from
593e0a9 to
4f2e70c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
==========================================
- Coverage 55.56% 55.54% -0.02%
==========================================
Files 400 400
Lines 50797 50797
==========================================
- Hits 28225 28216 -9
- Misses 20172 20180 +8
- Partials 2400 2401 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ghost
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve and fix debug logging in expect tests.