Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update vFuture consensus and configuration for 5MB blocks #4273

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Jul 19, 2022

Summary

This updates the vFuture consensus parameters for 5MB blocks, 3.5s filter timeout, and updates configuration defaults for the next release to use a larger assembly timeout and TX pool size.

Test Plan

Existing tests should pass.

@cce cce requested review from algorandskiy and brianolson July 19, 2022 21:50
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good except maybe localTemplate.go needs a version[24] ?

@brianolson
Copy link
Contributor

maybe add network/wsPeer.go maxMessageLength to this?

@brianolson
Copy link
Contributor

for comparison, this is what I've been running lately
#4262

@cce
Copy link
Contributor Author

cce commented Jul 21, 2022

@brianolson config v23 was just introduced in the 320-rounds branch so I think it is OK to tack these new defaults on to it.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #4273 (8211ddf) into master (3f64398) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
- Coverage   55.30%   55.27%   -0.04%     
==========================================
  Files         395      395              
  Lines       50333    50334       +1     
==========================================
- Hits        27838    27821      -17     
- Misses      20114    20121       +7     
- Partials     2381     2392      +11     
Impacted Files Coverage Δ
config/localTemplate.go 42.85% <ø> (ø)
network/wsPeer.go 65.47% <ø> (-6.03%) ⬇️
config/consensus.go 85.88% <100.00%> (+0.04%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
util/db/dbutil.go 49.09% <0.00%> (-1.22%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/verify/txn.go 44.00% <0.00%> (-0.89%) ⬇️
ledger/tracker.go 79.31% <0.00%> (+2.15%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cce cce merged commit 1806471 into algorand:master Jul 28, 2022
@cce cce deleted the update-params-5MB branch July 28, 2022 16:49
cce added a commit to cce/go-algorand that referenced this pull request Aug 5, 2022
…gorand#4273)

* update vFuture consensus and configuration for 5MB blocks
* remove obsoleted vFuture.AgreementFilterTimeoutPeriod0 = 4s
* update maxMessageLength to 6MiB
* update simulateAgreementWithLedgerFactory to support alternate FilterTimeout values since algorand#1896
* update VerifiedTranscationsCacheSize to 150k
* change AgreementFilterTimeoutPeriod0 = 3.4s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants