Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD: Optimizing CircleCI cache usage #4087

Merged
merged 2 commits into from
Jun 8, 2022
Merged

CICD: Optimizing CircleCI cache usage #4087

merged 2 commits into from
Jun 8, 2022

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Jun 7, 2022 •
edited
Loading

We have 3 caches:

  1. go mod + go sum
  2. libsodium
  3. go cache

Changes:

  • remove save after test stage (we don't need it)
  • make keys for caches not depend on stage name, but instead only on arch and OS, for better reuse
  • made go-cache save on every commit instead of each build
  • one of the keys was using a deprecated/non-working variable, changed it to a working one
  • invalidated cache by changing key name (also updating it for go-cache to be golang specific)

Tested in circleci by re-running

@algojack algojack self-assigned this Jun 7, 2022
@algojack algojack changed the title Optimizing CircleCI cache usage CICD: Optimizing CircleCI cache usage Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #4087 (6200d7d) into master (febeb1e) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
- Coverage   54.55%   54.50%   -0.05%     
==========================================
  Files         391      391              
  Lines       48662    48662              
==========================================
- Hits        26546    26524      -22     
- Misses      19890    19916      +26     
+ Partials     2226     2222       -4
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
node/node.go 22.42% <0.00%> (-1.87%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsNetwork.go 64.98% <0.00%> (-0.29%) ⬇️
network/wsPeer.go 68.21% <0.00%> (-0.28%) ⬇️
ledger/acctupdates.go 69.56% <0.00%> (+0.13%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febeb1e...6200d7d. Read the comment docs.

@algojack algojack requested review from a team, egieseke, algobarb and algolucky June 8, 2022 12:44
@algojack algojack marked this pull request as ready for review June 8, 2022 12:44
@onetechnical onetechnical merged commit f1036d5 into master Jun 8, 2022
@onetechnical onetechnical deleted the Optimizing-circleci-cache-usage branch June 8, 2022 13:20
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 11, 2022
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 21, 2022
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algolucky algolucky algolucky approved these changes

@cce cce cce approved these changes

@egieseke egieseke Awaiting requested review from egieseke egieseke was automatically assigned from algorand/devops

@algobarb algobarb Awaiting requested review from algobarb algobarb was automatically assigned from algorand/devops

Assignees

@algojack algojack

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algojack @cce @algolucky @onetechnical