add version to coin-generator #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algonautshant
approved these changes
May 18, 2022
| @@ -48,7 +48,8 @@ func (cc *coinChoiceSeed) ToBeHashed() (protocol.HashID, []byte) { | |||
| lnProvenWtAsBytes := make([]byte, 8) | |||
| binary.LittleEndian.PutUint64(lnProvenWtAsBytes, cc.lnProvenWeight) | |||
|
|
|||
| coinChoiceBytes := make([]byte, 0, len(cc.partCommitment)+len(lnProvenWtAsBytes)+len(cc.sigCommitment)+len(signedWtAsBytes)+len(cc.data)) | |||
| coinChoiceBytes := make([]byte, 0, 1+len(cc.partCommitment)+len(lnProvenWtAsBytes)+len(cc.sigCommitment)+len(signedWtAsBytes)+len(cc.data)) | |||
There was a problem hiding this comment.
Can you use len(cc.version) instead of 1+?
There was a problem hiding this comment.
Unfortunately , len(cc.version) does not compile
|
Can you please add a comment in the PR description? |
Codecov Report
@@ Coverage Diff @@
## feature/stateproofs #4007 +/- ##
=======================================================
- Coverage 49.93% 49.91% -0.03%
=======================================================
Files 412 412
Lines 69231 69233 +2
=======================================================
- Hits 34572 34558 -14
- Misses 30932 30940 +8
- Partials 3727 3735 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to support changes in the stateproof verifier, we need to add a version number to the coinChoiceSeed structure so that Fiat-Shamir could be used safely in the future.
Test Plan