Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goal: Rename source map output file #3905

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

algochoi
Copy link
Contributor

Summary

Follow up to #3726 - renamed source map file to match the output file rather than the input file to follow existing conventions more closely. Thanks to @jasonpaulos for the catch!

Test Plan

Changed an existing e2e test to match the new file path.

@algochoi algochoi self-assigned this Apr 21, 2022
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one edgecase comment, otherwise looks good!

cmd/goal/clerk.go Show resolved Hide resolved
@algochoi algochoi requested a review from michaeldiamant April 21, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants