Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algod:Stateproof server api #3888

Merged
merged 19 commits into from
May 2, 2022
Merged

algod:Stateproof server api #3888

merged 19 commits into from
May 2, 2022

Conversation

algonathan
Copy link
Contributor

Summary

adds basic state proof retrieval API to the algod.

Test Plan

@algonathan algonathan requested a review from id-ms April 14, 2022 13:36
@algonathan algonathan self-assigned this Apr 14, 2022
@algonathan algonathan marked this pull request as draft April 14, 2022 15:59
@id-ms
Copy link
Contributor

id-ms commented Apr 17, 2022

could we use the new API in the compact cart e2e test?

id-ms
id-ms reviewed Apr 17, 2022
View reviewed changes
Copy link
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! thanks!
few minor comments to address

daemon/algod/api/algod.oas2.json Show resolved Hide resolved
daemon/algod/api/server/v2/handlers.go Outdated Show resolved Hide resolved
daemon/algod/api/server/v2/handlers.go Outdated Show resolved Hide resolved
daemon/algod/api/server/v2/test/handlers_test.go Show resolved Hide resolved
daemon/algod/api/server/v2/test/handlers_test.go Outdated Show resolved Hide resolved
@id-ms id-ms marked this pull request as ready for review April 17, 2022 15:29
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022 •
edited
Loading

Codecov Report

Merging #3888 (2e96a21) into feature/stateproofs (1c3f705) will decrease coverage by 0.02%.
The diff coverage is 13.79%.

@@                   Coverage Diff                   @@
##           feature/stateproofs    #3888      +/-   ##
=======================================================
- Coverage                50.02%   50.00%   -0.03%     
=======================================================
  Files                      395      395              
  Lines                    68613    68640      +27     
=======================================================
- Hits                     34327    34325       -2     
- Misses                   30524    30550      +26     
- Partials                  3762     3765       +3
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
daemon/algod/api/server/v2/test/helpers.go 75.35% <66.66%> (-0.02%) ⬇️
ledger/tracker.go 73.39% <0.00%> (-1.29%) ⬇️
ledger/blockqueue.go 83.90% <0.00%> (-1.15%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
data/transactions/logic/eval.go 89.68% <0.00%> (+0.07%) ⬆️
network/wsPeer.go 68.61% <0.00%> (+0.27%) ⬆️
catchup/service.go 68.88% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3f705...2e96a21. Read the comment docs.

@id-ms id-ms merged commit 4009697 into algorand:feature/stateproofs May 2, 2022
@algonathan algonathan deleted the stateproof-server-api branch July 3, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@id-ms id-ms id-ms approved these changes

Assignees

@algonathan algonathan

Labels
Team Sphinx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algonathan @id-ms @codecov-commenter