Add support for rel/beta branch (and beta network) #193
Conversation
Intermittent problems running configure_dev.sh due to `brew tap cask` caused me to try to fix the reported error. And we don't want a buildnumber.dat in master.
cmd/algons/dnsCmd.go
Outdated
| @@ -268,7 +268,7 @@ func checkSrvRecord(dnsBootstrap string) { | |||
|
|
|||
| func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool { | |||
|
|
|||
| if network == "" || network == "testnet" || network == "devnet" || network == "mainnet" { | |||
| if network == "" || network == "testnet" || network == "devnet" || network == "mainnet" || network == "beta" { | |||
There was a problem hiding this comment.
nit: refactor into a const map lookup.
|
|
||
| git checkout rel/beta | ||
|
|
||
| # Disabled because we have static genesis files now |
There was a problem hiding this comment.
for this commented out block, cleanup rather than replicate?
There was a problem hiding this comment.
Sorry - just saw this. If i have to update again I will clean it up
* fix some branch assumptions * wait longer * fix rpm spec. note one way build_release.sh can hang * s/stable/CHANNEL/; make http more killable
Addressed PR feedback. Renamed `beta` to `betanet`. Fixed a few minor issues found in testing.
| @@ -268,7 +268,8 @@ func checkSrvRecord(dnsBootstrap string) { | |||
|
|
|||
| func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool { | |||
|
|
|||
| if network == "" || network == "testnet" || network == "devnet" || network == "mainnet" { | |||
| validNetworks := map[string]bool{"mainnet": true, "testnet": true, "devnet": true, "betanet": true} | |||
There was a problem hiding this comment.
if we're not going to make these common (here and cmd/goal/node.go ) can we at least put a comment to keep the other one up-to-date with this one (in both places) ?
There was a problem hiding this comment.
I would prefer to see the
validNetworks := map[string]bool{"mainnet": true, "testnet": true, "devnet": true, "betanet": true}
defined as
protectedNetworks := map[string]bool{"mainnet": true, "testnet": true, "devnet": true, "betanet": true}
but that shouldn't block you from merging in this change.
nit : define this in a single location rather than two..
Summary
Adds support for standing up a long-running network to do prolonged testing against a stable branch prior to releasing it to stable.
Test Plan
Verified branch builds as desired in travis and publishes
betapackages to S3. All builds passed.I've separately created an algonet-based network mirroring the configuration of devnet (5 hosts across 5 AWS regions with 1 relay and 4 nodes on each host - 20 nodes with 5% stake each).
Once this PR is merged to master, I'll delete the rel/beta branch and we'll create a new one once we're ready to snap for the next stable release.