Move peer.PrepareURL to net.SubstituteGenesisID #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianolson
approved these changes
Jan 11, 2021
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
The `wsPeer` doesn't provide any value in performing the GenesisID substitution; it's just reading the current value from the `wsNetwork` and calling the `strings.Replace` function. Moving this function to `wsNetwork` makes it much more encapsulated and avoid unneeded referencing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
wsPeerdoesn't provide any value in performing the GenesisID substitution; it's just reading the current value from thewsNetworkand calling thestrings.Replacefunction. Moving this function towsNetworkmakes it much more encapsulated and avoid unneeded referencing.The long-run plan is to try and de-couple the
wsPeerfromwsNetworkso thatwsPeerwould have awsNetworkinterface to work with ( not theGossipNode, but something more suitable for that particular "link" ). Once this is achieved, we should be able to write better testing forwsPeerwithout relying on the massivewsNetworkimplementation.Test Plan
Existing unit tests were updated.