Package pipeline #1629
Merged
Package pipeline #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really need to hold onto those between stages
egieseke
previously approved these changes
Oct 21, 2020
| @@ -44,19 +49,21 @@ tasks: | |||
| jobs: | |||
| package: | |||
| tasks: | |||
| - docker.Make.build | |||
There was a problem hiding this comment.
Why does packaging rebuild?
There was a problem hiding this comment.
I think the plan right now is to use the build artifacts produced by this pipeline rather than what travis uploads. That way we're only using travis to ensure that tests are passing.
Makefile
Outdated
| PATH=$(SRCPATH)/tmp/node_pkgs/$(OS_TYPE)/$(ARCH)/bin:$${PATH} \ | ||
| scripts/upload_version.sh $(CHANNEL) $(SRCPATH)/tmp/node_pkgs $(S3_RELEASE_BUCKET) | ||
| FULLBUILDNUMBER=$(FULLBUILDNUMBER) \ | ||
| aws s3 cp tmp/node_pkgs s3://algorand-internal/channel/${CHANNEL}/${FULLBUILDNUMBER} --recursive --exclude "*" --include "*${CHANNEL}*${FULLBUILDNUMBER}*" |
There was a problem hiding this comment.
Interesting, just to be clear here, this is uploading to algorand-internal, not algorand-staging, and will do so to a subdirectory based on the buildnumber? That should be fine, because it won't overlap with Travis's build artifacts if that's the case (uploads to the root of that dir).
btoll
reviewed
Oct 26, 2020
btoll
approved these changes
Oct 26, 2020
onetechnical
approved these changes
Oct 26, 2020
tsachiherman
pushed a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement mule packaging pipeline
Test Plan
This pipeline builds algorand, creates deb/rpm packages and uploads them to algorand-internal