Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableDeveloperAPI configuration flag #1191

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

tsachiherman
Copy link
Contributor

Summary

Add a local config to disable teal/compile in algod by default. This PR solves #1109.

The goal is to tie the TealCompile and DryRun in the algod REST endpoint with this new flag.
The DryRun functionality would be added with or after the application main PR, and this PR prepares the ground for that.

Test Plan

Unit test was updated to use the new construct.
This is a spinoff of the original PR #1163 by Shumo.

@tsachiherman tsachiherman linked an issue Jun 22, 2020 that may be closed by this pull request
@tsachiherman tsachiherman self-assigned this Jun 22, 2020
@tsachiherman tsachiherman marked this pull request as ready for review June 22, 2020 17:26
@tsachiherman tsachiherman requested review from stechu and winder June 22, 2020 17:26
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman
Copy link
Contributor Author

LGTM

thanks !

@tsachiherman tsachiherman merged commit 97143e5 into algorand:master Jun 22, 2020
@tsachiherman tsachiherman deleted the tsachi/teal/compile-config branch June 22, 2020 19:44
@tsachiherman
Copy link
Contributor Author

@pzbitskiy could you please verify that once you implement the dryrun api it would also be using the same EnableDeveloperAPI as above ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make /teal end points disabled by default
3 participants