Unify txFilename and outFilename vars usage in goal #1179
Conversation
There was a problem hiding this comment.
The change looks ok, but I cannot confirm that it would work, just by reviewing it.
Could you please add to the PR description the names of the expect tests that covers each of the changed commands ?
( i.e. in this change, I cannot rely on the compiler to tell me that it's not-used variable, or not-defined variable. nor can I see that the outFilename isn't used in a different location )
|
The change is simple - |
Summary
txFilename and outFilename variables in goal now are used consistently,
one for reading and another for writing out.
Test Plan
Rely on existing expect tests :
goal clerk send: test/e2e-go/cli/goal/expect/limitOrderTest.exp
goal asset * : test/e2e-go/cli/goal/expect/limitOrderTest.exp
goal clerk multisign merge: no current tests cover this change. Will open a ticket for creating these tests.
Background
applicationsbranch introduces a new common function for providing-o,--feeand so on common args. This PR fixes vars usage in existing code.