Unlimited assets changes #162
Conversation
|
|
tolikzinovyev
force-pushed
the
tolik/unlimited-assets
branch
from
df0020a to
e1fa507
Compare
|
@algonautshant @nicholasguoalgorand FYI: I started making changes to cucumber tests. |
| @@ -5,15 +5,14 @@ Feature: Indexer Client v2 Paths | |||
|
|
|||
| @unit.indexer | |||
| Scenario Outline: LookupAssetBalances path | |||
| When we make a Lookup Asset Balances call against asset index <index> with limit <limit> afterAddress "<afterAddress>" round <round> currencyGreaterThan <currencyGreaterThan> currencyLessThan <currencyLessThan> | |||
There was a problem hiding this comment.
this parameter was removed from indexer since it was never implemented
There was a problem hiding this comment.
This would break an existing test, make sure to update it instead of generating a new step in the SDKs
There was a problem hiding this comment.
Update which test?
There was a problem hiding this comment.
If you run them locally, your test fails. If you cannot see this, then either the sdk is not implementing this test, or you will see it fail once this job gets merge.
There was a problem hiding this comment.
Search for "we make a Lookup Asset Balances call against asset index" in the sdk, and you'll find the test.
There was a problem hiding this comment.
The test in the sdk, got it. I changed it in go sdk.
* fixes, file renames * error response data * add newline at the end of the files * fix names _as_ to _aa_ * replace filenames in the feature file * fix * indexer paths use real address
| | path | exclude | | ||
| | /v2/accounts?exclude=assets | assets | | ||
| | /v2/accounts?exclude=assets%2Ccreated-assets | assets,created-assets | | ||
| | /v2/accounts?exclude=assets%2Ccreated-assets%2Capps-local-state%2Ccreated-apps | assets,created-assets,apps-local-state,created-apps | |
There was a problem hiding this comment.
great, looks like you already have multiple excludes for some endpoints 👍
| | algod_unlimited_aa_Account_0.json | generated_responses_unlimited_assets | 200 | algod | AccountInformation | | ||
| | algod_unlimited_aa_Account_2.json | generated_responses_unlimited_assets | 200 | algod | AccountInformation | | ||
| | algod_unlimited_aa_AccountApplicationResponse_0.json | generated_responses_unlimited_assets | 200 | algod | AccountApplicationInformation | | ||
| | algod_unlimited_aa_AccountApplicationResponse_2.json | generated_responses_unlimited_assets | 200 | algod | AccountApplicationInformation | | ||
| | algod_unlimited_aa_AccountAssetResponse_0.json | generated_responses_unlimited_assets | 200 | algod | AccountAssetInformation | | ||
| | algod_unlimited_aa_AccountAssetResponse_2.json | generated_responses_unlimited_assets | 200 | algod | AccountAssetInformation | |
There was a problem hiding this comment.
@algonautshant do you know why we have 0 and 2 for these?
There was a problem hiding this comment.
Because of algorand/generator#25. Please approve and merge.
There was a problem hiding this comment.
nope. algorand/generator#25 did not fix it. Looking into it.
There was a problem hiding this comment.
I read toliks message as #25 explains the behavior.
There was a problem hiding this comment.
I have a fix. It is in the logic of accounting for num. It just looks strange, but can be fix later, since this is internal test.
New cucumber tests for unlimited assets.