Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): support translations in local storage recent searches plugins #1286

Conversation

justinedelson
Copy link
Contributor

Closes #1285

Summary

Passes through the translation to the underlying plugin

Result

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ba84f6:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@Haroenv Haroenv merged commit 893ad5f into algolia:next Nov 15, 2024
2 checks passed
@justinedelson
Copy link
Contributor Author

Thanks @Haroenv! Do you have a sense of when this will be released?

@Haroenv
Copy link
Contributor

Haroenv commented Nov 18, 2024

For now you'll need to use the preview or patch manually. We're currently in code freeze / release freeze for Black Friday period, so the scheduled release will be only in december

@justinedelson
Copy link
Contributor Author

@Haroenv just wanted to check in again since Black Friday is over.

@Haroenv
Copy link
Contributor

Haroenv commented Dec 5, 2024

Sorry, our bfcm deploy freeze ends on 9 December, it will be released then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations passed to LocalStorageRecentSearchesPluginOptions are not honored
2 participants