This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(types): improve conditional for client version #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in TypeScript 5.1.3, the check `any extends T` when T is any no longer evaluates to one branch of the conditional, but the union of both branches. This is fixed by using a "never possible to be true, unless T is any" condition as in https://stackoverflow.com/a/49928360/3185307 fixes algolia/instantsearch#5658 FX-2396
Haroenv
requested review from
a team,
dhayab and
FabienMotte
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ae94f98:
|
FabienMotte
approved these changes
Jun 13, 2023
this showed the error before the previous commit as
```
test/types.ts:16:7 - error TS2345: Argument of type '{ query: string; }' is not assignable to parameter of type 'PlainSearchParameters'.
Object literal may only specify known properties, and 'query' does not exist in type 'PlainSearchParameters'.
16 query: 'something fun',
~~~~~
Found 1 error in test/types.ts:16
error Command failed with exit code 2.
```
|
This test case was already covered in |
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…arch-helper-js#943) * fix(types): improve conditional for client version in TypeScript 5.1.3, the check `any extends T` when T is any no longer evaluates to one branch of the conditional, but the union of both branches. This is fixed by using a "never possible to be true, unless T is any" condition as in https://stackoverflow.com/a/49928360/3185307 fixes #5658 FX-2396 * chore(dev): update typescript this showed the error before the previous commit as ``` test/types.ts:16:7 - error TS2345: Argument of type '{ query: string; }' is not assignable to parameter of type 'PlainSearchParameters'. Object literal may only specify known properties, and 'query' does not exist in type 'PlainSearchParameters'. 16 query: 'something fun', ~~~~~ Found 1 error in test/types.ts:16 error Command failed with exit code 2. ```
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* fix(types): improve conditional for client version (algolia/algoliasearch-helper-js#943) algolia/algoliasearch-helper-js@d3273d6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in TypeScript 5.1.3, the check
any extends Twhen T is any no longer evaluates to one branch of the conditional, but the union of both branches.This is fixed by using a "never possible to be true, unless T is any" condition as in https://stackoverflow.com/a/49928360/3185307
fixes algolia/instantsearch#5658
FX-2396