Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Added select speedtest server job #1831

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[Feature] Added select speedtest server job #1831

merged 5 commits into from
Nov 25, 2024

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Nov 25, 2024 •
edited
Loading

📃 Description

This PR adds a step to the speedtest process to select a server from the config.

🪵 Changelog

➕ Added

  • SelectSpeedtestServer job to handle setting a server the speedtest CLI should use.

🔧 Fixed

  • when running a manual test, if no server is chosen let the CLI pick one

@alexjustesen alexjustesen added the 🧹 chore Nothing fancy, just needs to get done label Nov 25, 2024
@alexjustesen alexjustesen self-assigned this Nov 25, 2024
@alexjustesen alexjustesen changed the title added select speedtest server job [Chore] Added select speedtest server job Nov 25, 2024
@alexjustesen alexjustesen marked this pull request as ready for review November 25, 2024 15:40
@alexjustesen alexjustesen added 🎉 feature New feature or request and removed 🧹 chore Nothing fancy, just needs to get done labels Nov 25, 2024
@alexjustesen alexjustesen changed the title [Chore] Added select speedtest server job [Feature] Added select speedtest server job Nov 25, 2024
@alexjustesen alexjustesen merged commit 83a73ed into main Nov 25, 2024
1 check passed
@alexjustesen alexjustesen deleted the added-select-speedtest-server-job branch November 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexjustesen alexjustesen

Labels
🎉 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Manual speedtest does not let the Ookla CLI choose server.
1 participant
@alexjustesen