Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about table of contents on the right #138

Closed
rhuang opened this issue Jan 24, 2020 · 5 comments
Closed

question about table of contents on the right #138

rhuang opened this issue Jan 24, 2020 · 5 comments

Comments

@rhuang
Copy link

rhuang commented Jan 24, 2020 •
edited
Loading

I pulled the latest code on the theme from the submodule and the table of contents on the right is a bit different than the demo page in the smaller resolutions:

Demo;
Screen Shot 2020-01-23 at 9 07 58 PM

Mine:
Screen Shot 2020-01-23 at 9 07 55 PM

I can see the styling is a bit different. I've set BookToC: true and don't have any overrides in the individual pages. Can you help me understand why?

I also noticed when I take the v5 commit (995c1e6), the table of contents on the right doesn't trigger.

Screen Shot 2020-01-23 at 9 20 08 PM
@alex-shpak
Copy link
Owner

Hi!
Yesterday I pushed some changes to ToC behaviour to master, soon v6 will be released.
In v5 there is no support for ToC in mobile view, v6 will bring it.

It was not yet deployed at examples site.

This is how it supposed to look on mobile in latest revisions.
image

@rhuang
Copy link
Author

rhuang commented Jan 25, 2020

Cool. The demo site's ToC in mobile view is the "slide" version, I'm not sure what version that is.
It looks like v5 as well as the latest code on master both have the ToC version in your screenshot.

Just want to point out in the latest code on master that sometimes there is horizontal scrolling in the mobile resolutions:

Screen Shot 2020-01-25 at 3 24 51 PM

@alex-shpak
Copy link
Owner

Hi!
https://themes.gohugo.io/theme/hugo-book/ now picked latest master commit, so they are aligned.
About scroll bar - I will check, might be regression after this

alex-shpak added a commit that referenced this issue Feb 4, 2020
@alex-shpak
#138, Lower minimum body width from 400px to 320px, regression
4e03ee5
@alex-shpak
Copy link
Owner

Hi again!
Minimum body width used to be 320px, but after css rewrite became 400px, so I lowered it back. Note that scrollbar will start to appear lower that 320px anyway.

@rhuang
Copy link
Author

rhuang commented Feb 8, 2020

Thanks Alex, looks great!

I will close this issue now.

@rhuang rhuang closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhuang @alex-shpak