feat: update to Angular 11 #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `document` parameter in the `NbViewportRulerAdapter` constructor is now required.
BREAKING CHANGE: The `document` parameter in the `NbScrollDispatcherAdapter` constructor is now required.
`getLocaleDayNames` changed return value type to readonly array. Create new mutable array out of it to prevent breaking change in the date services `getDayOfWeekNames` method return value type.
Fixes incompatibilities with version of rxjs from @angular/devkit packages which caused types incompatibilities between rxjs entities of local rxjs and @angular/devkit/rxjs
Coloring utilities from `@angular-devkit/core/src/terminal` were removed. Use red color escape sequence insted. Bold text styling removed as warning message printed in bold anyway.
DeepCode's analysis on #a97f6f found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
`template.length` doesn't include whitespaces, qotes, etc.
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
+ Coverage 78.95% 78.97% +0.02%
==========================================
Files 253 253
Lines 7815 7815
Branches 857 857
==========================================
+ Hits 6170 6172 +2
+ Misses 1382 1379 -3
- Partials 263 264 +1
|
yggg
added a commit
that referenced
this pull request
Dec 24, 2020
(cherry picked from commit 847bc99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
Required Angular version is 11+.
The
documentparameter in theNbViewportRulerAdapterandNbScrollDispatcherAdapterconstructors is now required.