feat(user): Eva style #1354

yggg · 2019-04-04T09:40:12Z

Please read and mark the following check list before creating a pull request:

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

BREAKING CHANGES:

'isMenuShown' property removed from NbUserComponent.
'inverse' input removed from NbUserComponent.
'background' class renamed to 'initials'.
NbUserComponent SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE
size static properties were removed. Use NbComponentSize instead.

Size class names were prefixed with 'size-'.
small -> size-small
medium -> size-medium
large -> size-large
xlarge -> size-giant

Following properties were renamed:
user-font-size -> user-[size]-initials-text-font-size, user-[size]-name-text-font-size, user-[size]-title-text-font-size
user-line-height -> user-[size]-initials-text-line-height, user-[size]-name-text-line-height, user-[size]-title-text-line-height
user-bg -> user-picture-box-background-color
user-fg -> user-initials-text-color
user-fg-highlight -> user-picture-box-border-color
user-font-family-secondary -> user-name-text-font-family
user-size-small -> user-small-height, user-small-width
user-size-medium -> user-medium-height, user-medium-width
user-size-large -> user-large-height, user-large-width
user-size-xlarge -> user-giant-height, user-giant-width

NbUserComponent 'showNameValue', 'showTitleValue', 'showInitialsValue'
properties removed. Use 'showName', 'showTitle', 'showInitials' instead.

BREAKING CHANGES: 'isMenuShown' property removed from NbUserComponent.

BREAKING CHANGES: 'inverse' input removed from NbUserComponent.

BREAKING CHANGES: 'background' class renamed to 'initials'.

BREAKING CHANGES: NbUserComponent SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE size static properties were removed. Use NbUserSize instead.

BREAKING CHANGES: Size class names were prefixed with 'size-'. small -> size-small medium -> size-medium large -> size-large xlarge -> size-xlarge

BREAKING CHANGES: Following properties were renamed: user-font-size -> user-[size]-initials-text-font-size, user-[size]-name-text-font-size, user-[size]-title-text-font-size user-line-height -> user-[size]-initials-text-line-height, user-[size]-name-text-line-height, user-[size]-title-text-line-height user-bg -> user-picture-box-background-color user-fg -> user-initials-text-color user-fg-highlight -> user-picture-box-border-color user-font-family-secondary -> user-name-text-font-family user-size-small -> user-small-height, user-small-width user-size-medium -> user-medium-height, user-medium-width user-size-large -> user-large-height, user-large-width user-size-xlarge -> user-xlarge-height, user-xlarge-width

BREAKING CHANGE: NbUserComponent 'showNameValue', 'showTitleValue', 'showInitialsValue' properties removed. Use 'showName', 'showTitle', 'showInitials' instead.

codecov · 2019-04-04T09:49:21Z

Codecov Report

Merging #1354 into next will increase coverage by 0.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1354      +/-   ##
==========================================
+ Coverage   81.63%   81.96%   +0.32%     
==========================================
  Files         237      237              
  Lines        7275     7279       +4     
  Branches      626      627       +1     
==========================================
+ Hits         5939     5966      +27     
+ Misses       1150     1125      -25     
- Partials      186      188       +2

Impacted Files	Coverage Δ
.../framework/theme/components/user/user.component.ts	`100% <100%> (+41.66%)`	⬆️
...ramework/theme/components/badge/badge.component.ts	`77.41% <0%> (+9.67%)`	⬆️

src/framework/theme/components/user/_user.component.theme.scss

BREAKING CHANGE: 'isMenuShown' property removed from NbUserComponent. 'inverse' input removed from NbUserComponent. 'background' class renamed to 'initials'. NbUserComponent SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE size static properties were removed. Use NbComponentSize instead. Size class names were prefixed with 'size-'. small -> size-small medium -> size-medium large -> size-large xlarge -> size-giant Following properties were renamed: user-font-size -> user-[size]-initials-text-font-size, user-[size]-name-text-font-size, user-[size]-title-text-font-size user-line-height -> user-[size]-initials-text-line-height, user-[size]-name-text-line-height, user-[size]-title-text-line-height user-bg -> user-picture-box-background-color user-fg -> user-initials-text-color user-fg-highlight -> user-picture-box-border-color user-font-family-secondary -> user-name-text-font-family user-size-small -> user-small-height, user-small-width user-size-medium -> user-medium-height, user-medium-width user-size-large -> user-large-height, user-large-width user-size-xlarge -> user-giant-height, user-giant-width NbUserComponent 'showNameValue', 'showTitleValue', 'showInitialsValue' properties removed. Use 'showName', 'showTitle', 'showInitials' instead.

yggg added 13 commits April 4, 2019 12:14

refactor(user): remove unused property

1ce7a2a

BREAKING CHANGES: 'isMenuShown' property removed from NbUserComponent.

refactor(user): remove inverse input

95902d4

BREAKING CHANGES: 'inverse' input removed from NbUserComponent.

refactor(user): change initials class name to more descriptive

1fcfc64

BREAKING CHANGES: 'background' class renamed to 'initials'.

refactor(user): extract sizes into enum

ddecbe1

BREAKING CHANGES: NbUserComponent SIZE_SMALL, SIZE_MEDIUM, SIZE_LARGE, SIZE_XLARGE size static properties were removed. Use NbUserSize instead.

refactor(user): change size class names

369358b

BREAKING CHANGES: Size class names were prefixed with 'size-'. small -> size-small medium -> size-medium large -> size-large xlarge -> size-xlarge

docs(user): use existing size

940b421

fix(user): update setter type

1ad9333

fix(user): use proper theme variable

8e3e942

feat(theme): extract component sizes in type and scss function

bbab0d9

feat(user): add tiny and giant sizes

46e3714

feat(user): add tiny and giant sizes

5dbe6b8

BREAKING CHANGE: NbUserComponent 'showNameValue', 'showTitleValue', 'showInitialsValue' properties removed. Use 'showName', 'showTitle', 'showInitials' instead.

refactor(user): remove unnecessary size setter and getter

af4ee7e

yggg requested a review from nnixaa April 4, 2019 09:40

yggg and others added 6 commits April 4, 2019 15:52

Merge branch 'next' into feat/eva-user

154e4a8

test(user): add user component tests

b9b1d20

fix: import user, tabset and component variations from theme

2145395

docs(user): update theme properties list

a628a04

feat(user): add shape support

6edc47f

docs(user): add shape captions

894a991

nnixaa reviewed Apr 5, 2019

View reviewed changes

src/framework/theme/components/user/_user.component.theme.scss Show resolved Hide resolved

yggg and others added 2 commits April 5, 2019 14:46

Merge branch 'next' into feat/eva-user

a0ebe81

docs(user): add missing theme properties

33c7714

nnixaa approved these changes Apr 5, 2019

View reviewed changes

yggg merged commit b4b294c into akveo:next Apr 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(user): Eva style #1354

feat(user): Eva style #1354

yggg commented Apr 4, 2019

codecov bot commented Apr 4, 2019 •

edited

Loading

feat(user): Eva style #1354

feat(user): Eva style #1354

Conversation

yggg commented Apr 4, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

codecov bot commented Apr 4, 2019 • edited Loading

Codecov Report

codecov bot commented Apr 4, 2019 •

edited

Loading