Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nb-datepicker with NbDateFnsModule not working #1088

Closed
1 of 2 tasks
tomadj opened this issue Dec 16, 2018 · 1 comment · Fixed by #1117
Closed
1 of 2 tasks

nb-datepicker with NbDateFnsModule not working #1088

tomadj opened this issue Dec 16, 2018 · 1 comment · Fixed by #1117
Labels
bug module:components P1: urgent
Milestone
3.1.0

Comments

@tomadj
Copy link

tomadj commented Dec 16, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Hello,

Error bellow is throw but NbDateFnsDateModule is imported :

Can't format native date. To use custom formatting you have to install @nebular/moment or
@nebular/date-fns package and import NbMomentDateModule or NbDateFnsDateModule accordingly.

But not if I import NbMomentDateModule .

this error is throw in datepicker component :

NbBasePicker.prototype.ngOnChanges = function () {
        if (this.dateService instanceof NbNativeDateService && this.format) {
            throw new Error('Can\'t format native date. To use custom formatting you have to install @nebular/moment or ' +
                '@nebular/date-fns package and import NbMomentDateModule or NbDateFnsDateModule accordingly.' +
                'More information at "Formatting issue" ' +
                'https://akveo.github.io/nebular/docs/components/datepicker/overview#nbdatepickercomponent');
        }
    };

image

Maybe because NbDateFnsDateService extends NbNativeDateService ?

Thank's

Thomas

Angular, Nebular

    "@angular/cdk": "^7.1.1",
    "@angular/common": "^7.1.2",
    "@angular/compiler": "^7.1.2",
    "@angular/core": "^7.1.2",

    "@nebular/date-fns": "^3.0.1",
    "@nebular/moment": "^3.0.1",
    "@nebular/theme": "^3.0.1",
@ledsonsilva
Copy link

ledsonsilva commented Dec 26, 2018 •
edited
Loading

I'm also having this problem!

I have imported @nebular/date-fns into my component but I still get this error on console, speaking to import.

Next images:

captura de tela em 2018-12-26 08-55-15

captura de tela em 2018-12-26 08-55-51

captura de tela em 2018-12-26 08-56-56

@Tibing Tibing mentioned this issue Dec 29, 2018
Merged
2 tasks
@nnixaa nnixaa added this to the 3.1.0 milestone Dec 29, 2018
@issue-sh issue-sh bot removed the Backlog label Dec 30, 2018
nnixaa pushed a commit that referenced this issue Dec 30, 2018
@tibing-old-email @nnixaa
fix(datepicker): fix datepicker format not available error (#1117)
83cda23 
Closes #1088
@Luca1991 Luca1991 mentioned this issue Apr 8, 2019
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug module:components P1: urgent
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

fix(theme): datepicker format not available error akveo/nebular
4 participants
@nnixaa @tomadj @Tibing @ledsonsilva