chore: deprecate LoggerOps #32513
Merged
chore: deprecate LoggerOps #32513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
reviewed
Sep 9, 2024
| * or | ||
| * {{{ | ||
| *import akka.actor.typed.scaladsl._ | ||
| * }}} | ||
| * | ||
| * @param log the underlying [[org.slf4j.Logger]] | ||
| */ | ||
| @deprecated("Not needed in 2.13 and later", "2.10.0") |
There was a problem hiding this comment.
Isn't deprecating the class enough (and implicitly means all methods are deprecated as well)
There was a problem hiding this comment.
I was not sure. If you suggest, I can use that single-deprecation approach.
| @@ -17,15 +17,15 @@ package object scaladsl { | |||
| * Enable these extension methods with: | |||
| * | |||
| * {{{ | |||
| * import akka.actor.typed.scaladsl.LoggerOps | |||
| * }}} | |||
| * * }}} | |||
I looked again, but did not find 🙈 Can you point out a sample? |
sebastian-alfers
commented
Sep 9, 2024
| @@ -57,11 +56,11 @@ private class WeatherStation(context: ActorContext[WeatherStation.Command], wsid | |||
| private val stationUrl = s"http://${settings.host}:${httpPort}/weather/$wsid" | |||
|
|
|||
| def running: Behavior[WeatherStation.Command] = { | |||
| context.log.infoN(s"Started WeatherStation {} of total {} with weather port {}", | |||
There was a problem hiding this comment.
@johanandren Isn't this what you refer to?
There was a problem hiding this comment.
Ah indeed, sorry, everything is good then 👍
johanandren
approved these changes
Sep 9, 2024
| @@ -57,11 +56,11 @@ private class WeatherStation(context: ActorContext[WeatherStation.Command], wsid | |||
| private val stationUrl = s"http://${settings.host}:${httpPort}/weather/$wsid" | |||
|
|
|||
| def running: Behavior[WeatherStation.Command] = { | |||
| context.log.infoN(s"Started WeatherStation {} of total {} with weather port {}", | |||
There was a problem hiding this comment.
Ah indeed, sorry, everything is good then 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32500