bump: Agrona 1.22.0 #32489
bump: Agrona 1.22.0 #32489
Conversation
|
Note that Aeron 1.46.0 will require Agrona 1.23 or later, so no later Aeron until we drop JDK11 support. |
|
I'll add a comment about both. |
| val aeronVersion = "1.44.1" | ||
| // needs to be inline with the aeron version, check | ||
| // https://github.com/real-logic/aeron/blob/1.x.y/build.gradle | ||
| val agronaVersion = "1.19.2" | ||
| // Note: 1.23+ is JDK 17 only so we cannot bump until we stop supporting JDK 11 | ||
| val agronaVersion = "1.22.0" |
There was a problem hiding this comment.
looking at Test/dependencyTree in akka-cluster
[info] | +-io.aeron:aeron-client:1.44.1
[info] | | +-io.aeron:aeron-annotations:1.44.1
[info] | | +-org.agrona:agrona:1.23.0
[info] | | +-org.agrona:agrona:[1.21.1,2.0) (evicted by: 1.23.0)
I wonder where that agrona 1.23.0 comes from?
Also, why did this start failing 5 days ago? https://github.com/akka/akka/actions/workflows/nightly-builds.yml
There was a problem hiding this comment.
It seems the range [1.21.1,2.0) means that we already were on 1.22 but we never noticed, once they released JDK 17+ 1.23 it bumped for us. Some sbt resolution rule where it wins because range incompatible with our direct dependency I had not seen before.
There was a problem hiding this comment.
Incompatible as: we depended on 1.19 but range on aeron said it needed 1.21 minimum.
There was a problem hiding this comment.
wow, scary. dependencyTree is looking good in this branch
References #32488
Aeron 1.44.1 depends on a agrona range starting with 1.21.0 but up to 2.0, current agrona 1.23.0 has moved to target JDK 17 so we must stay on 1.22